bluetooth: Add some EIR fields #4273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniovazquezblanco
force-pushed
the
dev/eir
branch
4 times, most recently
from
895e857
to
90f38da
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4273 +/- ##
==========================================
+ Coverage 82.03% 82.04% +0.01%
==========================================
Files 350 350
Lines 82888 82929 +41
==========================================
+ Hits 67994 68036 +42
+ Misses 14894 14893 -1
|
gpotter2
reviewed
Feb 10, 2024
antoniovazquezblanco
force-pushed
the
dev/eir
branch
from
90f38da
to
30598b5
Compare
antoniovazquezblanco
force-pushed
the
dev/eir
branch
from
30598b5
to
e95d088
Compare
|
As said previously, it is not easy to find those fields out in the wild to test this as acuratelly as possible... I will add tests as soon as I come across a packet for the missing packets. For the time being I would like to merge the tested packets if possible. I can remove the untested packets from the PR if you wish so... Thanks! |
|
Would you prefer that I delete the non-tested packets or to leave them? Thanks |
gpotter2
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
cd test && ./run_testsortox)Bluetooth EIR packets.
Added few tests as I could not find data samples that I could share. I will try to collect some real world examples I can put there.